Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Remove the return_address intrinsic."" #34648

Closed
wants to merge 1 commit into from
Closed

Revert "Revert "Remove the return_address intrinsic."" #34648

wants to merge 1 commit into from

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jul 4, 2016

This reverts commit f698cd3.

Made possible by the merge of servo/servo#11872, this closes #34227 for good.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@jdm
Copy link
Contributor

jdm commented Jul 4, 2016

The Servo team are good with removing this once more.

@nagisa
Copy link
Member

nagisa commented Jul 4, 2016

cc @rust-lang/core

There has been an intent from you to get your hands dirty with this, so here’s the ping.

@nagisa
Copy link
Member

nagisa commented Jul 4, 2016

also @rust-lang/lang and @rust-lang/compiler

@nagisa
Copy link
Member

nagisa commented Jul 4, 2016

Note: apparently there’s a bunch of libcore copies out there (e.g. in redox), but the intrinsic is not actually used. These copies will begin to fail to build with nightlies once we remove the intrinsic, but in my eyes that’s acceptable.

@eddyb
Copy link
Member Author

eddyb commented Jul 4, 2016

@nagisa AFAICT it's not a literal copy, but a submodule pointing to a fork of rust-lang/rust.
The fork appears to just be pinned to an arbitrary commit, with no additional commits of their own.

@aturon
Copy link
Member

aturon commented Jul 5, 2016

Given that the affected users have signed off (as far as I know, this is basically just Servo), +1 from me.

@nikomatsakis
Copy link
Contributor

If servo is good, I'm good. 👍

@eddyb
Copy link
Member Author

eddyb commented Jul 5, 2016

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Jul 5, 2016

📌 Commit 0ec3d98 has been approved by nagisa

@bors
Copy link
Contributor

bors commented Jul 6, 2016

⌛ Testing commit 0ec3d98 with merge 4114b68...

bors added a commit that referenced this pull request Jul 6, 2016
@bors
Auto merge of #34648 - eddyb:return-in-peace-pls, r=nagisa
4114b68 
Revert "Revert "Remove the return_address intrinsic.""

This reverts commit f698cd3.

Made possible by the merge of servo/servo#11872, this closes #34227 for good.
@bors
Copy link
Contributor

bors commented Jul 6, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: nagisa
Pushing 4114b68 to master...

@alexcrichton
Copy link
Member

Apparently github didn't realize this was merged, closing.

@eddyb eddyb deleted the return-in-peace-pls branch July 6, 2016 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return_address intrinsic problematic with MIR and hard/impossible to use safely.
9 participants
@eddyb @rust-highfive @jdm @nagisa @aturon @nikomatsakis @bors @alexcrichton @brson